[iis] Fix service check on the _Total site
#2387
Conversation
| @@ -172,9 +172,15 @@ def ExecQuery(self, query, query_language, flags): | |||
| if query == ("Select ServiceUptime,TotalBytesSent,TotalBytesReceived,TotalBytesTransferred,CurrentConnections,TotalFilesSent,TotalFilesReceived," # noqa | |||
| "TotalConnectionAttemptsAllInstances,TotalGetRequests,TotalPostRequests,TotalHeadRequests,TotalPutRequests,TotalDeleteRequests," # noqa | |||
| "TotalOptionsRequests,TotalTraceRequests,TotalNotFoundErrors,TotalLockedErrors,TotalAnonymousUsers,TotalNonAnonymousUsers,TotalCGIRequests," # noqa | |||
| "TotalISAPIExtensionRequests from Win32_PerfFormattedData_W3SVC_WebService WHERE ( Name = 'Failing site' ) OR ( Name = 'Default Web Site' )"): # noqa | |||
| "TotalISAPIExtensionRequests from Win32_PerfFormattedData_W3SVC_WebService WHERE ( Name = 'Failing site' ) OR ( Name = 'Default Web Site' )"): | |||
There was a problem hiding this comment.
# noqa removed here but line is still pretty long, not sure if it would generate a flake8/pep8 warning... also it was kept in line 181 below. We should at least be consistent.
There was a problem hiding this comment.
Thanks for catching this, definitely shouldn't have been part of my changes.
|
Other than the nitpick, it looks good! 👍 |
|
Let's make sure CI passes though, something weird happened to Travis. |
olivielpeau
force-pushed
the
olivielpeau/fix-iis-service-check
branch
from
b85d542 to
2f6c3cb
Compare
|
Addressed your comment, thanks! The CI fails on python 2.6, apparently because of an issue with the install of psutil, I'll try to have a look, but I don't want to spend too much time on it since we'll stop supporting python2.6 soon. |
olivielpeau
force-pushed
the
olivielpeau/fix-iis-service-check
branch
from
2f6c3cb to
1c3c4d7
Compare
|
What version what this resolved in? 2016-04-26 15:17:39 GMT Daylight Time | WARNING | checks.iis(iis.py:141) | When extracting metrics with WMI, found a non digit value for property 'name'. |
|
Hi @bronandrews, The changes brought by this PR were shipped with 5.7.3, and fixed the service check that's sent by the IIS check on the The warnings you see in the collector logs are false positives that are unrelated to this issue and should not have any impact on the behavior of the IIS check. We'll work on removing these warnings as they are clearly misleading. Thanks! |
|
That's great - good to know there is no underlying issue. Many thanks for the swift response! |
Before 5.7.0, for
sitename == '_Total', we used to send a service check.5.7.0 to 5.7.2 were always sending a critical service check for this site name.
Go back to the previous behavior, and add a test case.
Should fix #2354