Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[process][win32] Add metric on opened handles #2403

Merged
merged 1 commit into from
Apr 7, 2016
Merged

[process][win32] Add metric on opened handles #2403

merged 1 commit into from
Apr 7, 2016

Conversation

olivielpeau
Copy link
Member

(would allow us to monitor that the agent doesn't have a handle leak)

@olivielpeau olivielpeau added this to the 5.8.0 milestone Apr 1, 2016
@yannmh
Copy link
Member

yannmh commented Apr 4, 2016

Why is it Windows specific ?

@olivielpeau
Copy link
Member Author

@yannmh Very basically, handles on Windows (see https://pythonhosted.org/psutil/#psutil.Process.num_handles) are the equivalent of file descriptors on Unix (see https://pythonhosted.org/psutil/#psutil.Process.num_fds)

@yannmh
Copy link
Member

yannmh commented Apr 5, 2016

Looks good 👍

@olivielpeau olivielpeau force-pushed the olivielpeau/process-num-handles branch from fd2e999 to e5a0a06 Compare April 7, 2016 00:11
@olivielpeau olivielpeau merged commit e626fa3 into master Apr 7, 2016
@olivielpeau olivielpeau deleted the olivielpeau/process-num-handles branch April 7, 2016 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yannmh yannmh

Labels
checks windows
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@olivielpeau @yannmh