[core] adds swap (pagefile) to windows stats #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
elasticsearch failures seem unrelated. checking. |
|
The failure is gone now, so I think it was unrelated. |
| @@ -178,6 +183,13 @@ def check(self, agentConfig): | |||
| pct_usable = float(usable) / total | |||
| self.save_sample('system.mem.pct_usable', pct_usable) | |||
|
|
|||
| page = psutil.virtual_memory() | |||
| if page.total is not None: | |||
There was a problem hiding this comment.
Do you know if it's possible to fetch this information from the Win32_PerfRawData_PerfOS_Memory WMI class ? See https://github.com/DataDog/dd-agent/blob/master/checks/system/win32.py#L91
There was a problem hiding this comment.
I don't know. I'll investigate.
There was a problem hiding this comment.
The answer is, in short, we can't because they're different. I cannot, at this moment, articulate the exact difference. I'm pretty sure that Win32_PerfRawData_PerfOS_Memory does not give you the actual pagefile usage, which is what we're trying to get here.
|
@gmmeyer Feel free to merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Windows pagefile statistics are not very robust. We've had a few requests to add more, better. This PR adds such metrics.
Now we're capturing the total size of the pagefile, how much is used, how much is available and the percent that's still free.
I've tested it on Windows, it seems to work fine, and the metrics come out looking pretty nice.