[mongo] more default metrics ↗ #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/mongodb-enhance-default-metrics
branch
2 times, most recently
from
34fb269 to
d319b0d
Compare
| option=option | ||
| if option in self.DEFAULT_METRICS: | ||
| self.log.warning( | ||
| u"`%s` option is deprecated and will be removed in a future version." |
There was a problem hiding this comment.
Not sure if will be removed in a future version, as it just does nothing anymore.
You can just say that it's not needed anymore.
|
all good besides my 2 nitpicks |
The following metric topics are now collected by default: * `dur` - journaling-related operations and performance report. * `locks` - serverstatus locks report. * `wiredtiger` - wiredtiger storage option. Log a warning to inform the user when any of these metric topics is listed in the configuration file.
Collect additional WiredTiger metrics, i.e. * `wiredTiger.cache.modified_pages_evicted`, * `wiredTiger.cache.unmodified_pages_evicted` Number of pages evicted from the cache * `wiredTiger.cache.tracked_dirty_bytes_in_cache` Amount of space taken by dirty data in the cache (bytes).
yannmh
force-pushed
the
yann/mongodb-enhance-default-metrics
branch
from
d319b0d to
2020e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mongo] more default metrics ↗
The following metric topics are now collected by default:
durability- journaling-related operations and performance report.locks- serverstatus locks report.wiredtiger- wiredtiger storage option.Log a warning to inform the user when any of these metric topics is
listed in the configuration file 🔊 .
[mongo] additional
wiredtigercache metricsCollect additional WiredTiger metrics, i.e.
wiredTiger.cache.modified_pages_evicted,wiredTiger.cache.unmodified_pages_evictedNumber of pages evicted from the cache
wiredTiger.cache.tracked_dirty_bytes_in_cacheAmount of space taken by dirty data in the cache (bytes).