[disk] Fix disk check exclusion #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2016 14:27
| # device name matches `excluded_disk_re` | ||
| elif not name_empty and self._excluded_disk_re.match(name): | ||
| return True | ||
| # device name matches `excluded_mountpoint_re` |
There was a problem hiding this comment.
this should be "device mountpoint"
|
@masci: Had a little discussion with myself, but apart from your own comment the PR looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2359 introduced a regression under the following circumstances:
''excluded_disk_reis not specified in the config file.In that case, the default pattern for
excluded_disk_rewas^$thus making_exclude_diskreturn before evaluatingexcluded_mountpoint_re.Also added a specific test for this issue and fixed the logic with a more verbose but easier to read pattern.