[powerdns_recursor] add integration #2490
Conversation
degemer
force-pushed
the
quentin/antocard-powerdns-recursor
branch
10 times, most recently
from
5d25218 to
25c0263
Compare
|
@AntoCard and @janeczku I restricted the metrics collected to the ones you advised, and used rates to collect the counter metrics: I think it's more useful to know the questions rate than the number of questions, please let me know if I'm wrong. @janeczku I think the metrics exposed by PowerDNS are too incomplete to be useful if converted to a histogram, so I also submitted them as rates. @AntoCard Thanks again for your initial PR ! |
| except Exception: | ||
| self.service_check(self.SERVICE_CHECK_NAME, AgentCheck.CRITICAL, | ||
| tags=service_check_tags) | ||
| raise |
There was a problem hiding this comment.
Would we want to raise a custom error here rather than just the exception that was thrown by requests?
There was a problem hiding this comment.
It could be nice, but since I have no idea what a non-2xx status means for PowerDNS, it wouldn't provide much more information than the default requests error.
So for now I'm going to keep it this way, if someone has an issue with the check, we'll update it to precise the error message.
|
I added a single note, but otherwise I think this looks fine. |
degemer
force-pushed
the
quentin/antocard-powerdns-recursor
branch
from
25c0263 to
0781d38
Compare
This check now only collects metrics deemed useful. It also sends a service check. The configuration file is cleaned, and a few comments are added for documentation purposes.
Build from source (:broken_heart:) and then test.
degemer
force-pushed
the
quentin/antocard-powerdns-recursor
branch
from
0781d38 to
2298a51
Compare
|
Thanks for the review @gmmeyer ! I'll wait for the 💚 CI before merging. |
This PR supersedes #2108.
It adds a service check, restrict metrics being collected, and adds integration tests.