[vsphere] skip host tags for broken instances #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the vSphere check fails on an instance, its metadata -stored in the class- may have not been populated. Thus, the collector fails and raises a `KeyError` exception when attempting to collect vSphere external host tags for the given instance, i.e. ``` 2016-05-23 10:10:13 Central Daylight Time | ERROR | checks.collector(logger.pyc:19) | Uncaught exception while running run Traceback (most recent call last): File "utils\logger.pyc", line 16, in wrapper File "checks\collector.pyc", line 486, in run File "checks\collector.pyc", line 699, in _populate_payload_metadata File "C:\Program Files (x86)\Datadog\Datadog Agent\files\..\checks.d\vsphere.py", line 511, in get_external_host_tags KeyError: 'foobar' ``` Do not raise, but log a warning instead.
|
|
ship it!
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
…-tags-broken-instances [vsphere] skip host tags for broken instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the vSphere check fails on an instance, its metadata -stored in the
class- may have not been populated.
Thus, the collector fails and raises a
KeyErrorexception whenattempting to collect vSphere external host tags for the given instance,
i.e.
Do not raise, but log a warning instead.