[docker] be resilient to dockerpy buggy api calls #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, 🍰 for adding test coverage. |
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
…events [docker] be resilient to dockerpy buggy api calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug on docker-py, whenever the Docker api fails at returning a stream of events, the library returns a plain string instead of a Json as expected, thus raising warnings on collector's logs.
Waiting for docker/docker-py#1082 to be merged, this PR increases agent resilience to this problem.
The fix was tested by couple of customers.