Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: support github.com/riverqueue/river #3103

Open
wijayaerick opened this issue Jan 19, 2025 · 1 comment
Open

proposal: support github.com/riverqueue/river #3103

wijayaerick opened this issue Jan 19, 2025 · 1 comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals

Comments

@wijayaerick
Copy link

wijayaerick commented Jan 19, 2025

river is a background job library written in Go. It would be great to add a native integration for this library.

River provides JobInsertMiddleware and WorkerMiddleware which can be used to inject/extract tracing data.

If this proposal is accepted, I'd be happy to contribute. I've created issue in the river repository as well (riverqueue/river#709) which include initial draft for the implementation. One thing I'm not quite sure is what data should be included in the span tags; I think we could refer from delayed_job from dd-trace-rb as it's also a background job library.

@wijayaerick wijayaerick added the enhancement quick change/addition that does not need full team approval label Jan 19, 2025
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Jan 19, 2025
@darccio darccio added apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals and removed needs-triage New issues that have not yet been triaged labels Jan 21, 2025
@darccio
Copy link
Member

darccio commented Jan 21, 2025

@wijayaerick Thanks for contributing! We'll be happy to review it once you open the PR in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals
Projects
None yet
Development

No branches or pull requests

2 participants