Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumenting ConnectWebhandlers in Meteor #2356

Open
ajax88 opened this issue Sep 8, 2022 · 1 comment
Open

Instrumenting ConnectWebhandlers in Meteor #2356

ajax88 opened this issue Sep 8, 2022 · 1 comment

Comments

@ajax88
Copy link

ajax88 commented Sep 8, 2022

Hi all - I was wondering what the best way to instrument the WebApp.connectHandlers provided by meteor. We use these connectHandlers to expose different webhooks, yet I don't see any tracing related to a connect service that I expect to see. Given that this seems to just be a wrapper around connect, I'm wondering why the built in dd-trace connect instrumentation does not work in this case. I'm guessing this must be due to some misunderstanding I have with the way dd-trace monkey-patches different packages. For context, I'm well aware of the inherent incompatibility that Meteor has with dd-trace due to the Fibers <> async_hooks incompatibility: #1229; that being said, I don't believe my current question should be affected by this.

I'm happy to provide more context here, just let me know what would be good to know.
Thanks!

@ajax88
Copy link
Author

ajax88 commented Sep 8, 2022

To add to this a bit, it seems like connect should be instrumented based on the tracer configuration I'm seeing here:

DATADOG TRACER CONFIGURATION - {"date":"2022-09-08T14:48:09.945Z","os_name":"Darwin","os_version":"21.3.0","architecture":"x64","version":"0.29.1","lang":"nodejs","lang_version":"12.20.1","env":"localhost","enabled":true,"scope_manager":"async_resource","service":"tradewing","agent_url":"http://127.0.0.1:8126","debug":false,"analytics_enabled":true,"sample_rate":1,"sampling_rules":[],"tags":{"service":"tradewing","env":"localhost","version":""},"log_injection_enabled":true,"runtime_metrics_enabled":false,"integrations_loaded":["[email protected]","connect","[email protected]","[email protected]","fs","[email protected]","http","net","dns","[email protected]","https","[email protected]","[email protected]"]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant