[pdh] improvements + integrations should use wheel if available #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
jaime/pdhfixes
branch
3 times, most recently
from
2c3c4d9 to
da6f218
Compare
truthbk
commented
Apr 16, 2018
There was a problem hiding this comment.
dd-agent testing branch should be restored back to master. There's a weird testing dependency cycle. I would first switch this to master and merge. Then switch DataDog/dd-agent#3691. Then trigger a CI run on integrations-core manually.
.travis.yml
Outdated
| @@ -26,7 +26,7 @@ env: | |||
| - PIP_CACHE=$HOME/.cache/pip | |||
| - SDK_TESTING=true | |||
| - BUNDLE_PATH=$TRAVIS_BUILD_DIR/vendor/cache | |||
| - DD_AGENT_BRANCH=master | |||
| - DD_AGENT_BRANCH=jaime/pdhwheel | |||
There was a problem hiding this comment.
Must be switched back to master after DataDog/dd-agent#3691 is merged.
appveyor.yml
Outdated
| @@ -8,7 +8,7 @@ environment: | |||
| NOSE_FILTER: not unix and not fixme and not winfixme | |||
| PYWIN_PATH: C:\projects\integrations-core\.cache\pywin32-py2.7.exe | |||
| SKIP_LINT: true | |||
| DD_AGENT_BRANCH: master | |||
| DD_AGENT_BRANCH: jaime/pdhwheel | |||
There was a problem hiding this comment.
Must be switched back to master after DataDog/dd-agent#3691 is merged.
truthbk
force-pushed
the
jaime/pdhfixes
branch
3 times, most recently
from
31adb41 to
6edab3d
Compare
[appveyor] add pdh_check to the tox invoke task
[pdh] load base class from `datadog_checks_base` [pdh] fixing multiple issues
might break CI until counterpart PRs merged in dd-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All PDH related integrations should use the PDH check provided by the wheel. We really don't want to maintain this in multiple places.
Motivation
Single source of PDH in wheels.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?