[RabbitMQ] add a protocol if there isn't one #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
suggested changes
Nov 28, 2017
| # urlparse.urljoin cannot add a protocol to the rest of the url for some reason. | ||
| # This still leaves the potential for errors, but such urls would never have been valid, either | ||
| # and it's not likely to be useful to attempt to catch all possible mistakes people could make | ||
| base_url = 'http://' + base_url |
There was a problem hiding this comment.
How does this play with kubernetes/autoconfig? See #838
There was a problem hiding this comment.
Actually http://rabbitmq-management.default:443 would work, so we're good.
masci
previously approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now if a protocol isn't specified, a bunch of rabbit requests will fail. This is not great. They shouldn't fail. To be specific, if a url has no protocol,
urlparse.urljoinwill behave in an anomalous manner. This PR will address part of the issue that we saw in #838.For example:
So, we have to assign it a protocol. We'll assume http.
Motivation
This is an old bug that has tripped up a bunch of people.
Versioning
manifest.jsonCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
There are other ways people can mess up urls. If someone puts in a url like: '//gmmeyer.com' or '://gmmeyer.com' or something, it should fail. We cannot attempt to fix every permutation of how people can get their urls wrong. This just assumes that if a url is bare, it's meant to have an http protocol--which is what requests does anyway