[etcd] adding /health to etcd check #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpoint of the etcd instance) Signed-off-by: Massimiliano Pippi <[email protected]>
Signed-off-by: Massimiliano Pippi <[email protected]>
olivielpeau
reviewed
Dec 4, 2017
etcd/check.py
Outdated
| else: | ||
| self.log.debug("Missing 'health' key in stats, can't determine health status.") | ||
|
|
||
| self.service_check(self.HEALTH_SERVICE_CHECK_NAME, state, tags=instance_tags+["url:{0}".format(url)]) |
There was a problem hiding this comment.
isn't the url: tag already in the instance_tags list (see code 10 lines above)
masci
force-pushed
the
massi/etcd
branch
3 times, most recently
from
e65aa72 to
6e518b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See DataDog/dd-agent#2678
Versioning
manifest.jsonCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.