Adding 'histogram' metric type to JMXFetch. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
force-pushed
the
maxime/jmxfetch-histogram
branch
from
ba1b09c to
d25f838
Compare
yannmh
reviewed
Dec 7, 2016
| public void assertMetric(String name, List<String> tags, int countTags, String metricType){ | ||
| assertMetric(name, -1, tags, new ArrayList<String>(), countTags, metricType); | ||
| } | ||
|
|
||
| /** |
| @@ -70,7 +70,7 @@ public void sendMetrics(LinkedList<HashMap<String, Object>> metrics, String inst | |||
| String[] tags = Arrays.asList((String[]) metric.get("tags")).toArray(new String[0]); | |||
|
|
|||
| // StatsD doesn't support rate metrics so we need to have our own aggregator to compute rates | |||
| if (!"gauge".equals(metricType)) { | |||
| if ("counter".equals(metricType)) { | |||
There was a problem hiding this comment.
I am worried that this breaks backward compatibility with configuration that did not have counter properly spelt (!"gauge".equals versus "counter".equals). What do you think?
There was a problem hiding this comment.
Indeed ! I will reverse the condition to explicitly catch "gauge" and "histogram".
For the next major release, I imagine that we should clarify the condition to only accept known types ?
We now support 'histogram' type for metric (in addition of 'gauge' and 'counter').
hush-hush
force-pushed
the
maxime/jmxfetch-histogram
branch
from
d25f838 to
3fee419
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support 'histogram' type for metric (in addition of 'gauge' and 'counter').
This is a first step toward blacklisting tags (as different points may have the same tags set).