Maxime/jmxfetch exclude tags #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
force-pushed
the
maxime/jmxfetch-exclude-tags
branch
2 times, most recently
from
32f4d6d to
8e54007
Compare
This is usefull to filter out unique tags like host/client id, ... This may/should be use in combination with the 'histogram' metric_type to avoid loosing metric points.
hush-hush
force-pushed
the
maxime/jmxfetch-exclude-tags
branch
from
8e54007 to
ee9cf50
Compare
yannmh
approved these changes
Dec 9, 2016
| for (Iterator<String> it = this.defaultTagsList.iterator(); it.hasNext();) { | ||
| if (it.next().startsWith(excludedTagName + ":")) { | ||
| it.remove(); | ||
| } |
There was a problem hiding this comment.
Instead of this double for loop, can we have the getExcludeTags method to return a Set, and only iterates over defaultTagsList performing lookups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is usefull to filter out unique tags like host/client id, ...
This may/should be use in combination with the 'histogram' metric_type to avoid loosing metric points.