[attribute][complex] extend to java.util.Map
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Mar 2, 2017
olivielpeau
reviewed
Mar 2, 2017
| @@ -34,7 +34,7 @@ private void populateSubAttributeList(Object attributeValue) { | |||
| for (String key : data.getCompositeType().keySet()) { | |||
| this.subAttributeList.put(key, new HashMap<String, Object>()); | |||
| } | |||
| } else if ("java.util.HashMap".equals(attributeType)) { | |||
| } else if (("java.util.HashMap".equals(attributeType)) || ("java.util.Map".equals(attributeType))){ | |||
| HashMap<String, Double> data = (HashMap<String, Double>) attributeValue; | |||
There was a problem hiding this comment.
I don't think this cast will work in the general case when the underlying attributeValue object is not a HashMap.
Have you tested this with a non-HashMap Map?
There was a problem hiding this comment.
(we could probably just cast attributeValue to a Map right?)
same applies to your change line 86
There was a problem hiding this comment.
You're right it should stay a Map
Add `java.util.Map` to the list of supported `JMXComplexAttribute` types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
java.util.Mapto the list of supportedJMXComplexAttributetypes.
Fix #125