Allow the troubleshooting commands to use the IPC endpoint #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
changed the title
truthbk
reviewed
Apr 16, 2018
| @@ -136,6 +136,11 @@ public static void main(String[] args) { | |||
|
|
|||
| App app = new App(config); | |||
|
|
|||
| // Get config from the ipc endpoint for "list_*" actions | |||
| if (!config.getAction().equals(AppConfig.ACTION_COLLECT)) { | |||
There was a problem hiding this comment.
Wondering if this might break stuff on agent5? Can you verify? Maybe we should add a flag to enable this behavior?
There was a problem hiding this comment.
It should not since the A5 does not give the IPC config parameters.
jmxfetch/src/main/java/org/datadog/jmxfetch/App.java
Lines 73 to 75 in 1e163cf
jmxfetch/src/main/java/org/datadog/jmxfetch/AppConfig.java
Lines 132 to 134 in 1e163cf
^
getJSONConfigs is a no-op in A5
| @@ -107,7 +107,7 @@ public HttpResponse request(String method, String body, String path) { | |||
| con.setRequestMethod(method.toUpperCase()); | |||
| con.setRequestProperty("Authorization", "Bearer "+ this.token); | |||
| con.setRequestProperty("User-Agent", USER_AGENT); | |||
| if (method.toUpperCase() == "GET") { | |||
| if (method.toUpperCase().equals("GET")) { | |||
arbll
force-pushed
the
arbll/https-config-troubleshooting
branch
from
1e163cf to
2c61140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to give configs to
list_*commands using the HTTPS IPC endpoint.