Add a new command to test rate metrics #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For end to end testing, we use the `list_with_metrics` command. It only does one iteration though, which means we don't have output for counters and rates. This adds a new command running 2 iterations.
therve
force-pushed
the
therve/list-rate-metrics
branch
from
07d110a to
e81284b
Compare
truthbk
reviewed
Feb 18, 2020
| @@ -49,11 +51,14 @@ public void doSendServiceCheck(String checkName, String status, String message, | |||
| System.out.println("=== JSON ==="); | |||
| ObjectMapper mapper = new ObjectMapper(); | |||
| mapper.enable(SerializationFeature.INDENT_OUTPUT); | |||
| StringWriter writer = new StringWriter(); | |||
Ideally we'd have a command with a parameter flag. If we change the current we'll break our end to end tests. It may not be a huge deal, but in regular tests we like having the distinction between rate and non-rate. |
truthbk
approved these changes
Feb 21, 2020
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For end to end testing, we use the
list_with_metricscommand. It onlydoes one iteration though, which means we don't have output for counters
and rates. This adds a new command running 2 iterations.