Replace Map metric by a Metric class #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbempel
changed the title
jpbempel
force-pushed
the
jpbempel/newMetricClass
branch
from
71256ff to
95d59a6
Compare
jpbempel
force-pushed
the
jpbempel/newMetricClass
branch
from
95d59a6 to
2fb7b10
Compare
During collection process, metrics are collected as Map<String, Object>, but keys are known and fixed so we can replace this map to a POJO which will be lighter in term of memory footprint and allocation.
jpbempel
force-pushed
the
jpbempel/newMetricClass
branch
from
2fb7b10 to
6aafa60
Compare
truthbk
approved these changes
Feb 21, 2020
| // We need to edit metrics for legacy reasons (rename metrics, etc) | ||
| Map<String, Object> metric = new HashMap<String, Object>(m); | ||
| // TODO: There is no obvious reason to duplicate this object here. should be removed. | ||
| Metric metric = new Metric(m.getAlias(), m.getMetricType(), m.getValue(), m.getTags()); |
There was a problem hiding this comment.
Not sure I see a reason for this allocation either, maybe we should remove it and just work with Metric m? It doesn't seem like the comment above is true anymore "we need to edit metrics for legacy reasons".
|
@jpbempel going to merge this. Please feel free to address any of the feedback, which didn't affect any of the logic introduced here, in a follow-up PR. Thank you! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During collection process, metrics are collected as
Map<String, Object>, but keys are known and fixed so we can replace
this map to a POJO which will be lighter in term of memory footprint
and allocation.