Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the '--log_format_rfc3339' option to the console logger #308

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Apply the '--log_format_rfc3339' option to the console logger #308

merged 2 commits into from
Jul 7, 2020

Conversation

hush-hush
Copy link
Member

Apply the --log_format_rfc3339 option to the console logger.

@hush-hush hush-hush force-pushed the maxime/fix-console-rfc3339 branch from 981863e to 4d580f6 Compare July 2, 2020 21:08
@hush-hush hush-hush force-pushed the maxime/fix-console-rfc3339 branch from 4d580f6 to bad97d5 Compare July 2, 2020 21:13
truthbk
truthbk approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended! Tested manually after reviewing code.

Pushed a small commit to fix the tests, we're exceeding the 4MB output cap on Travis, so downgraded to INFO level and made it easily configurable; tests are now green.

@truthbk truthbk merged commit 30bc13e into master Jul 7, 2020
@truthbk truthbk deleted the maxime/fix-console-rfc3339 branch July 7, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hush-hush @truthbk