[status] track dogstatsd client errors #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh123man
previously approved these changes
Oct 30, 2020
| import lombok.extern.slf4j.Slf4j; | ||
| import org.datadog.jmxfetch.Instance; | ||
| import org.datadog.jmxfetch.JmxAttribute; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicInteger; |
There was a problem hiding this comment.
NIT: I don't this import is used in this context
There was a problem hiding this comment.
Thanks, bad cleanup from my end! :)
gh123man
previously approved these changes
Oct 30, 2020
mcculls
added a commit
to DataDog/dd-trace-java
that referenced
this pull request
Apr 19, 2021
(This is the shared client version of DataDog/jmxfetch#336)
mcculls
added a commit
to DataDog/dd-trace-java
that referenced
this pull request
Apr 19, 2021
Support tracking of StatsD client errors (This is the shared client version of DataDog/jmxfetch#336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow us to tap into potential errors happening in the java dogstatsd client that we might otherwise not have good visibility into. This isn't particularly rich, but at least it'll allow support, and us, to quickly identify potential issues on socket operations. This is particularly interesting in the case of UDS, where we could have drops happening at the socket level - this would result in gaps in our customers timeseries - but not be able to prove otherwise.