[build] Prevent double signing of release artifacts #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mvn verify` step was creating `*.asc` files which were then signed again when run with `mvn deploy` even though the `maven-gpg-plugin` documentation explicitly mentions that they should be ignored. Since `mvn deploy` will automatically invoke `verify`, this change ensures that the artifacts are signed only once.
remeh
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mvn verifystep was creating*.ascfiles which were then signedagain when run with
mvn deployeven though themaven-gpg-plugindocumentation explicitly mentions that they should be ignored. Since
mvn deploywill automatically invokeverify, this change ensuresthat the artifacts are signed only once.