Use slf4j+java.util.logging for logging needs.
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Dec 20, 2021
sgnn7
reviewed
Dec 20, 2021
Comment on lines
40
to
43
| /** contains returns if the given log level is contained. | ||
| * If this level is `OFF`, `contains` returns `true` only if `other` is `OFF` | ||
| * as well. | ||
| */ |
There was a problem hiding this comment.
nit: Javadoc-like comments in this file probably need a bit standardization/formatting
Co-authored-by: Srdjan Grubor <[email protected]>
sgnn7
approved these changes
Dec 20, 2021
olivielpeau
reviewed
Dec 20, 2021
Otherwise, the root logger remains at the INFO level and finer log levels can't be configured successfully
We need to match slf4j-jdk14's mapping. Also, add a test.
olivielpeau
reviewed
Dec 20, 2021
Old code had a file count set to 1 which would effectively cause the content of the file never to rotate. Setting this value to 2 ensures that we have 2 log files wherever possible (1 current, 1 rolled over).
olivielpeau
reviewed
Dec 21, 2021
olivielpeau
reviewed
Dec 21, 2021
Co-authored-by: Olivier Vielpeau <[email protected]>
olivielpeau
approved these changes
Dec 21, 2021
olivielpeau
added a commit
that referenced
this pull request
Dec 21, 2021
Also bumps SLF4J from 1.7.26 to 1.7.32. Co-authored-by: truthbk <[email protected]> Co-authored-by: Srdjan Grubor <[email protected]> Co-authored-by: Olivier Vielpeau <[email protected]> Co-authored-by: Olivier Vielpeau <[email protected]>
olivielpeau
added a commit
that referenced
this pull request
Dec 21, 2021
Also bumps SLF4J from 1.7.26 to 1.7.32. Co-authored-by: truthbk <[email protected]> Co-authored-by: Srdjan Grubor <[email protected]> Co-authored-by: Olivier Vielpeau <[email protected]> Co-authored-by: Olivier Vielpeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMXFetch needs for logging features are fairly small, this PR is switching all the logging to use
java.util.loggingSLF4J bindings.All features (file logging with rotation, stdout, stderr, log levels, rfc3339 date time format support) should still be present.
Some rough performances tests have been used to confirm that JMXFetch still performs well when it logs a lot, even if it is not really verbose in default scenarios.
This PR bumps SLF4J from
1.7.26to1.7.32.