Make StatsD client queue size and telemetry configurable #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
We might want to add a way to add tags to the client telemetry in the future. This is currently unsupported on the client, so I'll just create a card to add that feature in the future. We can still use the client version and client tags to differentiate the telemetry from other applications.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the StatsD client queue size and telemetry configurable.
Telemetry is useful to debug issues with the submission of metrics, and bumping the queue size fixes issues with contexts being dropped when JMXFetch grabs a high number of contexts and tries to enqueue them all after it's collected them.
See the instantiation parameters in the docs.