Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad regression with Status type #49

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Conversation

yannmh
Copy link
Member

@yannmh yannmh commented Apr 2, 2015

Switching Status type from String to int introduced a bad regression in Datadog agent.

2015-04-01 15:08:57,849 | ERROR | dd.collector | checks.check_status(check_status.py:776) | Couldn't load latest jmx status
> Traceback (most recent call last):
>  File "/home/vagrant/workspace/dd-agent/checks/check_status.py", line 759, in get_jmx_status
>    check_data[check_name]['statuses'].append(get_jmx_instance_status(instance_name, status, message, metric_count))
>  File "/home/vagrant/workspace/dd-agent/checks/check_status.py", line 688, in get_jmx_instance_status
>    return instance_status
> UnboundLocalError: local variable 'instance_status' referenced before assignment

This PR reverts the change introduced in:
https://github.com/DataDog/jmxfetch/pull/38/files#diff-c6d094e1c3c4dcd3b460b535995a43ccR14

@wang-arthur @remh

@yannmh yannmh added the bug label Apr 2, 2015
@yannmh yannmh self-assigned this Apr 2, 2015
@yannmh yannmh added this to the 5.3.0 milestone Apr 2, 2015
@remh
Copy link

remh commented Apr 3, 2015

lgtm!

remh pushed a commit that referenced this pull request Apr 3, 2015
fix bad regression with `Status` type
@remh remh merged commit 56d092f into master Apr 3, 2015
@yannmh yannmh deleted the yann/fix-bad-regression branch November 9, 2015 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants