Ya memory improvement: queryMBeans→queryNames
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,9 +31,9 @@ | |||
| private static final String DOT_UNDERSCORE = "_*\\._*"; | |||
| private MBeanAttributeInfo attribute; | |||
| private Connection connection; | |||
| private ObjectInstance jmxInstance; | |||
| private ObjectName jmxInstance; | |||
There was a problem hiding this comment.
Could you rename this attribute to beanName like you did in JMXSimpleAttribute and JMXComplexAttribute ? 😃
|
Just a few minor comments to address, apart from those it looks good to merge once the ci passes! 👍 |
yannmh
force-pushed
the
yann/query-mbean-names-only
branch
3 times, most recently
from
0a586bd to
b10d275
Compare
|
Comments addressed. Thanks for the review @olivielpeau ! |
JMXFetch was unnecessarily querying full bean objects: query bean names instead (`queryMBeans`→`queryNames`). As it queries one bean attributes at a time (`getAttributesForBean`), extra memory is saved.
yannmh
force-pushed
the
yann/query-mbean-names-only
branch
from
b10d275 to
f83e119
Compare
yannmh
added a commit
that referenced
this pull request
Aug 26, 2015
Ya memory improvement: `queryMBeans`→`queryNames`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMXFetch was unnecessarily querying full bean objects: query bean names
instead (
queryMBeans→queryNames).As it queries one bean attributes at a time (
getAttributesForBean),extra memory is saved.