Yann/cassandra metric mapping update #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/cassandra-metric-mapping-update
branch
from
bded66d to
08b09ac
Compare
|
@remh can you take a quick pass on the last commit please ? |
| @@ -60,8 +60,6 @@ public void sendMetrics(LinkedList<HashMap<String, Object>> metrics, String inst | |||
| // We need to edit metrics for legacy reasons (rename metrics, etc) | |||
| HashMap<String, Object> metric = new HashMap<String, Object>(m); | |||
|
|
|||
| postProcess(metric); | |||
There was a problem hiding this comment.
You can also remove this method's definition, along with postProcessCassandra that is not used anymore.
yannmh
force-pushed
the
yann/cassandra-metric-mapping-update
branch
from
08b09ac to
fc558c6
Compare
This change does several things: * Maintains parity for the deprecated Cassandra namespaces * Remaps metric names to cassandra.$metric or cassandra.$metric.$attribute * Drops name:$name tag because of redundancy * Renames scope:$scope to $type:$scope so users can continue to use 'columnfamily:mytable`, for instance [[email protected]] Rebased on JMXFetch v0.8.0
yannmh
force-pushed
the
yann/cassandra-metric-mapping-update
branch
from
fc558c6 to
1eca3c5
Compare
|
Thanks @olivielpeau. |
|
Any thought on the |
Create a `cassandra_aliasing` flag to select the appropriate aliasing logic. * `cassandra_aliasing` → compliant with CASSANDRA-4009 * default behavior
yannmh
force-pushed
the
yann/cassandra-metric-mapping-update
branch
from
1eca3c5 to
941f6ec
Compare
|
Looks good to me! Don't have any better idea for the parameter name 😕 |
yannmh
added a commit
that referenced
this pull request
Nov 3, 2015
Map Cassandra new metric name structure
yannmh
added a commit
to DataDog/dd-agent
that referenced
this pull request
Nov 3, 2015
**Changes** * [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [#81][] * [FEATURE] Support `float` and `java.lang.Float` attribute types as * simple JMX attributes. See [#76][] * [FEATURE] Support Cassandra > 2.2 metric name structure * (CASSANDRA-4009). See [#79][] * [FEATURE] Support custom JMX Service URL to connect to, on a * per-instance basis. See [#80][] * [IMPROVEMENT] Assign generic alias if not defined. See [#78][] <!--- The following link definition list is generated by PimpMyChangelog ---> [#76]: DataDog/jmxfetch#76 [#78]: DataDog/jmxfetch#78 [#79]: DataDog/jmxfetch#79 [#80]: DataDog/jmxfetch#80 [#81]: DataDog/jmxfetch#81
urosgruber
pushed a commit
to urosgruber/dd-agent
that referenced
this pull request
Dec 23, 2015
**Changes** * [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [DataDog#81][] * [FEATURE] Support `float` and `java.lang.Float` attribute types as * simple JMX attributes. See [DataDog#76][] * [FEATURE] Support Cassandra > 2.2 metric name structure * (CASSANDRA-4009). See [DataDog#79][] * [FEATURE] Support custom JMX Service URL to connect to, on a * per-instance basis. See [DataDog#80][] * [IMPROVEMENT] Assign generic alias if not defined. See [DataDog#78][] <!--- The following link definition list is generated by PimpMyChangelog ---> [DataDog#76]: DataDog/jmxfetch#76 [DataDog#78]: DataDog/jmxfetch#78 [DataDog#79]: DataDog/jmxfetch#79 [DataDog#80]: DataDog/jmxfetch#80 [DataDog#81]: DataDog/jmxfetch#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #50
Added changes
Create a
cassandra_aliasingflag to select the appropriate aliasing logic.cassandra_aliasing→ compliant with CASSANDRA-4009