-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Naming of module on case-insensitive filesystems #287
Comments
This does feel like an issue where TL;DR - It sounds like the best course of action would be to rename the root import path to use the more common captialized version; although I'm not extremely fond of making that breaking change (changing all other |
Case-conflicting import paths cause issues when using `go mod vendor` as the layout on case-sensitive file systems is different from that on case-insensitive file system. This is a long-known issue with the Go toolchain, however fixing this is non-trivial and could have undesirable consequences. Since the capitalized form of `DataDog` (sic) is most common today, renaming the `orchestrion` module is the most pragramtic solution today. Caused-By golang/go#38342 Fixes #287
Case-conflicting import paths cause issues when using `go mod vendor` as the layout on case-sensitive file systems is different from that on case-insensitive file system. This is a long-known issue with the Go toolchain, however fixing this is non-trivial and could have undesirable consequences. Since the capitalized form of `DataDog` (sic) is most common today, renaming the `orchestrion` module is the most pragramtic solution today. Caused-By golang/go#38342 Fixes #287
Version of orchestrion
Latest version (0.8.1)
Describe what happened:
On MacOS, installing
go install github.com/datadog/orchestrion@latest
and thengo mod vendor
putting to orchestrion tovendor/github.com/DataDog
instead ofvendor/github.com/datadog
, because others packets in dependency installs asjackfan.us.kg/DataDog/...
If run same set of commands on Ubuntu 20.04, these locations will be separated:
If
orchestrion
is on the same system where it was installed, everything is working, but when moving between systems (developer working on MacOS, but compiling app on Ubuntu with Jenkins), there are problems with linking.Describe what you expected:
Consistent path naming between DataDog modules:
Steps to reproduce the issue:
Push code to case-sensitive filesystem, try to run

orchestrion go ...
. Then rungo mod vendor
and then look at file structure atvendor/github.com
Additional environment details (Version of Go, Operating System, etc.):
Go 1.22.6
MacOS Sequoia 15.0, APFS filesystem (not case-sensitive or encrypted)
Ubuntu 20.04.6 LTS, ext4 filesystem
The text was updated successfully, but these errors were encountered: