[service_discovery] adding jmx check for service discovery #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alvin-huang 👍 This was surely due, and makes plenty of sense given the new feature. We're going to have to pin Thanks! |
|
@alvin-huang could you be so kind as to rebase this to the latest master? That should fix up the CI issues we encountered in the past with the unwanted |
alvin-huang
force-pushed
the
add_jmx_check_sd
branch
from
0b7b3a7 to
7ccdfca
Compare
|
@truthbk not a problem-- rebased and ready to go! |
truthbk
approved these changes
Mar 10, 2017
|
Thanks for the rebase! Merging in this one! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #287