Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tomcat integration #390

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Fix tomcat integration #390

merged 1 commit into from
Feb 19, 2018

Conversation

oshmyrko
Copy link

@oshmyrko oshmyrko commented Feb 7, 2018

This fixes tomcat integration when some its metrics start reporting wrong values (jumps and drops) after tomcat restart. This PR adds only two lines with attribute: after type: Cache and type: JspMonitor.

image

Also, config for tomcat integration, which are shipped with Datadog agent package, already contains these changes, but Datadog documentation does not have the lines with attribute:.

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly correct! Thank you very much @oshmyrko - merging!

@truthbk truthbk added this to the 2.0.0 milestone Feb 19, 2018
@truthbk truthbk merged commit 7d045a2 into DataDog:master Feb 19, 2018
@oshmyrko oshmyrko deleted the tomcat_integration branch March 3, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants