Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes to Kafka, Consul, stdlib deprecations #404

Merged
merged 8 commits into from
Mar 5, 2018

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Mar 2, 2018

  • We have to slowly deprecate all legacy calls, and when we do make legacy calls for validation, let's rely on validate_legacy. In general we will move towards setting types for parameters, and we'll do so gradually, customers should not be affected by the changes, and the test suite should keep us honest.
  • Consul: improved testing
  • Kafka: added support for Agent6, it must've been left out when support was added for the beta.
  • Functions for agent6 tagging: remove derecated calls.

@truthbk truthbk added this to the 2.1.0 milestone Mar 2, 2018
@truthbk truthbk self-assigned this Mar 2, 2018
Copy link
Member Author

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unilateral merge - tested on puppet 4/5

@truthbk truthbk merged commit 597c887 into master Mar 5, 2018
@truthbk truthbk deleted the jaime/consulspec branch March 5, 2018 12:57
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* [kafka] adding Agent6 support

* [consul][spec] adding more extensive tests

* [functions] remove legacy validations

* [manifest] more stdlib 4.24.0 deprecation fixes

* [agent6] fix tagging.

* [legacy] fix tests for older rubies

* [apt][metadata] dropping lower bound to 2.4.0 for increased compatibility

* [functions] fix typo in tag6, use variable in recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant