Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL integration should not require password parameter #409

Closed
thebearmayor opened this issue Mar 8, 2018 · 2 comments
Closed

MySQL integration should not require password parameter #409

thebearmayor opened this issue Mar 8, 2018 · 2 comments
Assignees
@truthbk
Milestone
2.2.0

Comments

@thebearmayor
Copy link

https://github.com/DataDog/puppet-datadog-agent/blob/master/manifests/integrations/mysql.pp requires a password parameter (no default) even when passed instances. When instances are specified, they have their own password parameters, and the top-level parameter is not used. In addition, it was recently changed to validate specifically as a String, breaking any users who passed undef for clarity.
@truthbk truthbk self-assigned this Mar 8, 2018
@truthbk truthbk added this to the 2.2.0 milestone Mar 8, 2018
@truthbk
Copy link
Member

truthbk commented Mar 8, 2018

@thebearmayor thank you for reporting this.

@thebearmayor
Copy link
Author

I intended to submit a fix for this myself, but I checked out the code, ran rake spec and got hundreds of failures. Is that normal?

@truthbk truthbk mentioned this issue Mar 9, 2018
Merged
@truthbk truthbk closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@truthbk truthbk

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@truthbk @thebearmayor