Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specification of CA cert for HTTP status check #418

Merged
merged 5 commits into from
Apr 16, 2018
Merged

Allow specification of CA cert for HTTP status check #418

merged 5 commits into from
Apr 16, 2018

Conversation

ffleming
Copy link
Contributor

This PR allows Puppet to specify ca_certs for HTTP status checks

Forrest Fleming added 3 commits February 16, 2018 11:49
add ca_certs configuration
5683962
test for ca_certs line
025eb25
fix scoping bug
40d48ac 
previously, the ca_certs conditional was nested in the 'tls cert
check is disabled' conditional.  while it doesn't make a _ton_ of sense
to provide a ca cert when you aren't checking it, allowing users to do
so makes migrating from an unchecked to a checked workflow easier.  I
don't see a downside to allowing this behavior.
@ffleming
Copy link
Contributor Author

ffleming commented Mar 20, 2018 •
edited
Loading

All build errors appear to be of the form:

Required ruby-2.1.9 is not installed - installing.
curl: (7) Failed to connect to s3.amazonaws.com port 443: Connection timed out
curl: (7) Failed to connect to s3.amazonaws.com port 443: Connection timed out
Searching for binary rubies, this might take some time.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm ruby-2.1.9 do rvm gemset create ' first, or append '--create'.
The command "rvm use 2.1.9 --install --binary --fuzzy" failed and exited with 2 during .
Your build has been stopped.

I got that with 2.1.9 x 3, 2.3.6, and 2.2.3. It looks like a rebuild would fix (S3 connectivity issue), but I'd rather not spam a useless commit to trigger a re-run. How would you prefer to proceed?

Cheers!

truthbk
truthbk approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the tests 🍰 !! Sorry for the slow response.

Really appreciated @ffleming

@truthbk truthbk merged commit 0bf223a into DataDog:master Apr 16, 2018
@truthbk truthbk added this to the 2.2.0 milestone May 16, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
@ffleming @truthbk
Allow specification of CA cert for HTTP status check (DataDog#418)
ce6ca3f 
* add ca_certs configuration

* test for ca_certs line

* fix scoping bug

previously, the ca_certs conditional was nested in the 'tls cert
check is disabled' conditional.  while it doesn't make a _ton_ of sense
to provide a ca cert when you aren't checking it, allowing users to do
so makes migrating from an unchecked to a checked workflow easier.  I
don't see a downside to allowing this behavior.

* whitespace to trigger build

* Revert "whitespace to trigger build"

This reverts commit e875f27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ffleming @truthbk