Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moises.botarro/adding new config fields for process agent scrubbing #426

Conversation

moisesbotarro
Copy link
Contributor

The fields used by the process-agent's new feature, process args scrubbing, have been added on the templates for datadog.conf and datadog.yaml files.

  • A new footer file's been created to handle the process-agent config section on the datadog.conf file.
  • The default values have also been set.
  • Tests have been added on the datadog_spec file.

…ed hashmap to configure yaml file; added datadog_process_footer.conf.erb to handle datadog.conf generation; updated README.md with new fields
@conorbranagan
Copy link
Contributor

lgtm! I'll leave to Jaime for the 👍

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We'll test and release soon - probably next week. Awesome work! 🍰

@truthbk truthbk merged commit a82c61a into master Apr 25, 2018
@truthbk truthbk deleted the moises.botarro/adding-new-config-fields-for-process-agent-scrubbing branch April 25, 2018 15:41
@truthbk truthbk added this to the 2.2.0 milestone May 16, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
…ataDog#426)

* Added default values for scrub_args and custom_sensitive_words; updated hashmap to configure yaml file; added datadog_process_footer.conf.erb to handle datadog.conf generation; updated README.md with new fields

* Added test for conf and yaml files

* Format changes

* Fixed regex patterns on data scrubbing tests

* [process][spec] address test-case conflict - `enabled` not `process_enabled`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants