Remove indentation of the pgbouncer template to match the needed format of configuration file #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of configuration file
With the current template the output of the configuration if the tags field was set was wrongly indented:
Output Example:
```
init_config:
instances:
- host: localhost
port: 5678
username: datadog
password: some-interesting-password
tags:
- dbinstanceidentifier:some-instance-identifier
```
The agent in this scenario was working right but if the integration with pgbouncer was not working as the tag field was wrongly indented.
With this change, the format will be the following
```
init_config:
instances:
- host: localhost
port: 5678
username: datadog
password: some-interesting-password
tags:
- dbinstanceidentifier:some-instance-identifier
```
Making the integration work if tags are specified.
truthbk
approved these changes
Apr 25, 2018
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…t of configuration file (DataDog#427) With the current template the output of the configuration if the tags field was set was wrongly indented: Output Example: ``` init_config: instances: - host: localhost port: 5678 username: datadog password: some-interesting-password tags: - dbinstanceidentifier:some-instance-identifier ``` The agent in this scenario was working right but if the integration with pgbouncer was not working as the tag field was wrongly indented. With this change, the format will be the following ``` init_config: instances: - host: localhost port: 5678 username: datadog password: some-interesting-password tags: - dbinstanceidentifier:some-instance-identifier ``` Making the integration work if tags are specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current template, the output of the configuration is wrong indented if the tags field was set
Output Example:
In this scenario the pgbouncer integration doesn't work, when run
datadog-agent statusI get the following:With this fix, the format will be the following
Making the integration works if tags are specified.