Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apm_enabled yaml #466

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix apm_enabled yaml #466

merged 1 commit into from
Nov 13, 2018

Conversation

NoodlesNZ
Copy link
Contributor

In the APM config the option to enable/disable APM is enabled not apm_enabled. Currently if you have $apm_enabled set to false, APM will still be enabled.

@truthbk
Copy link
Member

truthbk commented Oct 24, 2018

Thanks @NoodlesNZ, this is correct, thank you for submitting the fix. Could you please fix the spec test that is now broken due to the change? The tests are still looking for /^\ \ apm_enabled: false\n/...

Thank you very much! 🙇

@NoodlesNZ
Copy link
Contributor Author

Ok, this has been fixed up.

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@truthbk truthbk merged commit b10ea5b into DataDog:master Nov 13, 2018
@truthbk truthbk added this to the 2.4.0 milestone Dec 20, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants