Support DD EU in reporter #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicalixte
force-pushed
the
remicalixte/site-report
branch
from
b8f1b1b to
64a5a41
Compare
truthbk
suggested changes
Nov 28, 2018
manifests/reports.pp
Outdated
| @@ -15,6 +15,7 @@ | |||
| # | |||
| class datadog_agent::reports( | |||
| $api_key, | |||
| $datadog_site, | |||
There was a problem hiding this comment.
This would not be backward compatible if referenced on its own. It's fine in the context of init.pp, but if someone has already written a custom manifest using datadog_agent::reports, this would break it. You'll need to add a default (probably an empty string, or the US site).
There was a problem hiding this comment.
Oh I see, I didn't know it was a public interface
There was a problem hiding this comment.
This is a weird edge case that might not affect anyone, but it's not hard to fix on our side, so let's better be safe than sorry. 🙇
There was a problem hiding this comment.
Should be fixed now
remicalixte
force-pushed
the
remicalixte/site-report
branch
6 times, most recently
from
4ef5507 to
6044e30
Compare
remicalixte
force-pushed
the
remicalixte/site-report
branch
from
6044e30 to
fa05e3e
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* Write api_url in the report config * Use api_url to choose datadog host * Update spec tests * Add a default value for datadog_site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to apply on top of #464