Fix trying to call .empty? on an integer #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
force-pushed
the
albertvaka/integer-slowlog_max_len
branch
from
963ed21 to
2f48dd4
Compare
`slowlog_max_len` can be either int or string.
albertvaka
force-pushed
the
albertvaka/integer-slowlog_max_len
branch
from
2984feb to
37a4344
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…g_max_len Fix trying to call .empty? on an integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slowlog_max_lencan be either int or string. Always cast it to string.I haven't been able to run the tests locally. I hope this is the correct way to cast to string in puppet and the tests pass on the CI.