Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support puppet 6 #537

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Support puppet 6 #537

merged 3 commits into from
Jun 25, 2019

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jun 19, 2019

  • yumrepo has been moved to a separate module in puppetforge.
  • Added ruby 2.6 to the travis matrix, and excluded puppet 6 + ruby < 2.3 because it's not supported.

@albertvaka albertvaka force-pushed the albertvaka/puppet-6 branch from 0536add to 8cc1d8e Compare June 20, 2019 08:21
@albertvaka albertvaka force-pushed the albertvaka/puppet-6 branch from 86a5c53 to d1020e6 Compare June 20, 2019 08:48
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are a couple of Travis failures, it wasn't immediately obvious to me what was failing.

@albertvaka
Copy link
Contributor Author

albertvaka commented Jun 20, 2019

Restarting fixed it 😞 It failed pulling from puppetforge, so might have been a network issue.

@albertvaka albertvaka merged commit 32b6036 into master Jun 25, 2019
@albertvaka albertvaka deleted the albertvaka/puppet-6 branch June 25, 2019 14:12
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants