Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters to http_check #599

Merged

Conversation

asenci
Copy link
Contributor

@asenci asenci commented Jan 13, 2020

Add the check_hostname and ssl_server_name parameters
to the http_check integration

Add the check_hostname and ssl_server_name parameters
to the http_check integration
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch :) I left a couple minor comments.

manifests/integrations/http_check.pp Outdated Show resolved Hide resolved
manifests/integrations/http_check.pp Outdated Show resolved Hide resolved
@albertvaka
Copy link
Contributor

Looks good to me! Thanks again @asenci :)

@albertvaka albertvaka merged commit 0b24c8d into DataDog:master Jan 14, 2020
@albertvaka
Copy link
Contributor

This just went out in version 3.1.0.

@asenci asenci deleted the asenci/add_ssl_server_name_to_http_check branch January 14, 2020 21:09
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Add the check_hostname and ssl_server_name parameters
to the http_check integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants