Update report processor to add tag function based on Puppet facts. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify report class to manage report tags from facts through datadog config yaml file.
albertvaka
reviewed
Jul 24, 2020
cswatt
approved these changes
Jul 24, 2020
Co-authored-by: Albert Vaca <[email protected]>
|
thanks for the updates @cswatt and good catch @albertvaka |
|
Merging then :) Thanks a ton for your patches! 🙇 |
Merged
|
@murdok5 I'm trying to extend this to add support for trusted facts. Is there something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify report class to manage report tags from facts through Datadog
config yaml file.
What does this PR do?
This PR enables a new parameter to be set that specifies which Puppet facts will be added as tags to each report sent to DataDog as an event.
Motivation
Working with a customer we found that correlating DataDog events and metrics was challenging and using Puppet Facts would simplify this problem.
Additional Notes
This is outside my typical expertise and as such I would request detailed review/comments/opinions/testing from anyone.
Describe your test plan
Using a current release of Datadog and Puppet Enterprise at the time of this PR I validated functionality and updated the readme with specific tips and note on how to use. I modified the values, deployed the Puppet code, restarted puppetserver service, and validated the new facts were appearing on the next Puppet run reports in Datadog.