Fix Package not depending on the right Yumrepo #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
force-pushed
the
albertvaka/package-requires-yumrepo
branch
2 times, most recently
from
01db139 to
c3f5c18
Compare
albertvaka
force-pushed
the
albertvaka/package-requires-yumrepo
branch
from
c3f5c18 to
d88dc3e
Compare
mx-psi
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
LGTM, docs say manage_repo is deprecated so I suppose we should revisit this at some point, but it makes sense to keep it like this for now
puppet-datadog-agent/manifests/init.pp
Lines 76 to 78 in d88dc3e
|
Whenever we do a new major version we should remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
packageresource required theYumrepocalleddatadog6instead ofdatadog, which was wrong.Also I think we were using an empty
packageresource to force theyumrepobeing created, but we can actually use that samepackageinstance to install the datadog-agent package if we specify it instead of doing that right after. Changed that as well.Motivation
Should fix: #659