Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to remove integration #674

Closed
cdloh opened this issue Dec 1, 2020 · 1 comment · Fixed by #675
Closed

Ability to remove integration #674

cdloh opened this issue Dec 1, 2020 · 1 comment · Fixed by #675

Comments

@cdloh
Copy link

cdloh commented Dec 1, 2020

At present if you create an integration the module creates the required folder and config file as required.

If you later don't want this integration there is no way to mark it as absent or remove it.

It'd be nice if this was possible.

Could manage the entire conf directory so that files are automatically cleaned up that aren't managed in Puppet or make the ensure param configurable so that it would be possible to just pass absent if you want to cleanup integrations later on.

IMO managing the whole folder is cleaner.

@cdloh cdloh changed the title Remove integration. Ability to remove integration Dec 1, 2020
@cdloh
Copy link
Author

cdloh commented Dec 7, 2020

Can we reopen this?

Whilst that fixes removing manual integrations, there is still no way to remove specific integrations eg

datadog_agent::integrations::nginx it'll just sit there on disk.

Edit: NVM. Just realised you can set conf_dir_purge to true. Didn't realise that was exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant