Add the 'current' gpg key, only use 1 gpgkey on suse < 15 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
approved these changes
Mar 18, 2021
| @@ -30,7 +31,7 @@ | |||
| } | |||
| 7 : { | |||
| $defaulturl = "https://yum.datadoghq.com/stable/7/${::architecture}/" | |||
| $gpgkeys = $keys[1,2] | |||
| $gpgkeys = $keys[0,-2] | |||
There was a problem hiding this comment.
Not something this PR introduced (so we can fix that separately), but specifying indices directly is a bit ugly. Would be a bit cleaner to have different arrays like $keys_a5, $keys_a6, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The special DATADOG_RPM_KEY_CURRENT.public entry will always contain the key that is used to sign current metadata as well as newly released packages. This PR also fixes the gpgkey entry on SUSE < 15, where zypper only respects the first value.
Motivation
Additional Notes
Describe your test plan