Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figlet types are missing "parseFont" method #38318

Closed
patorjk opened this issue Sep 12, 2019 · 1 comment
Closed

figlet types are missing "parseFont" method #38318

patorjk opened this issue Sep 12, 2019 · 1 comment

Comments

@patorjk
Copy link

patorjk commented Sep 12, 2019

I maintain the figlet repo. A user (@andytan0727) put in an issue (patorjk/figlet.js#50 (comment)) mentioning that the parseFont method is missing from the index.d.ts file:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/figlet/index.d.ts

I am not that familiar with TypeScript, so I don't want to put in a PR, but I believe this is what would need to be added: (inside of the figlet namespace)

function parseFont(fontName: string, data: string): FontOptions;

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants