Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound local error in rivers method #113

Closed
DirkEilander opened this issue Oct 10, 2022 · 1 comment · Fixed by #110
Closed

unbound local error in rivers method #113

DirkEilander opened this issue Oct 10, 2022 · 1 comment · Fixed by #110
Labels
bug Something isn't working

Comments

@DirkEilander
Copy link
Contributor

The else statement in rivers should be lowered to fix a potential unbound local error if no river geoms is found and not river mask is found.

This error is raised when building the docs for the update_model_gauges.ipynb example (see action referenced below), but was not raised before. We should carefully check why both the rivers geom and river mask map are not available anymore!

https://github.com/Deltares/hydromt_wflow/actions/runs/3187682388/jobs/5260892285

@DirkEilander DirkEilander added the bug Something isn't working label Oct 10, 2022
@hboisgon
Copy link
Contributor

This seems to be linked to #108 , the model with updated gauges is not created so no rivers can be found. But anyway indeed the unbound local error should be removed in self.rivers

@hboisgon hboisgon linked a pull request Oct 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants