Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - Conductance distribution: River cells where stage equals bottom elevation are dropped #1386

Closed
JoerivanEngelen opened this issue Jan 20, 2025 · 0 comments · Fixed by #1387
Closed

[Bug] - Conductance distribution: River cells where stage equals bottom elevation are dropped #1386

JoerivanEngelen opened this issue Jan 20, 2025 · 0 comments · Fixed by #1387
Assignees
@JoerivanEngelen
Labels
bug Something isn't working

Comments

@JoerivanEngelen
Copy link
Contributor

When distributing the conductances, conductances are masked in river cells where stage equals bottom elevation. This happens in _compute_crosscut_thickness. I'd expected this to be an edge case, but the LHM features quite some river cells where stage equals bottom elevation.
@JoerivanEngelen JoerivanEngelen added the bug Something isn't working label Jan 20, 2025
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 20, 2025
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🏗 In Progress in iMOD Suite Jan 20, 2025
@JoerivanEngelen JoerivanEngelen self-assigned this Jan 20, 2025
@JoerivanEngelen JoerivanEngelen mentioned this issue Jan 20, 2025
Merged
5 tasks
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Jan 20, 2025
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
bug Something isn't working
Projects
iMOD Suite
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1386 distribute conductance stage equals bottom elevation Deltares/imod-python
1 participant
@JoerivanEngelen