-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make easy to load default datasets #269
Comments
That's a helpful feature. Two concerns:
Instead I would use a pattern such as:
BTW, this reminded me that the |
No, it is a common pattern used by all the popular libraries, also The idea is just to encapsulate all this logic:
into a method, so that the user can avoid knowing all these details. Accepting your notes that could be:
So that parameters can be passed if needed. Users will still be able to use |
Thank you @Mec-iS , that helps me much understand better. I see about the convenience method, although arguably this is a practice that create extra cognitive load, with PyTorch being an example cited. For files used in our tutorials we want to emphasize examples of how to load or save files in storage, ideally as Posix files. The thinking is: this way there are less differences to overcome when people try to apply code from our examples for their own projects. One problem we've encountered during Q&A is that there are namespaces which are difficult to understand, such as the RDF prefix namespace. Moving between different libraries (e.g., RDF vs. NetworkX) also introduces API namespaces to navigate. 'm apprehensive about adding a dataset namespace, since these are only for tutorial example sand not part of the library usage in production. FWIW, I found this exchange between the |
I'm submitting a
Current Behaviour:
It is hard to load any of the default datasets.
Expected Behaviour:
there should be a straighforward way of loading existing datasets, for example:
Every dataset should have a name that if passed to
load_dataset
provides automatic imports of the dataset in a given graph; as for example provided byscikit-network
load collectionThe text was updated successfully, but these errors were encountered: