"Maximum call stack size exceeded" when create many Proxy instance using same handler

[link89]

Hi, we found that there is a chance that when using testcafe to test a mbox based SPA, "Maximum call stack size exceeded" error will occur during case execution.

It turns out the root cause of this error is because hammerhand overwrite window.Proxy.
Here is a minimal reproduce script

const handler = {
    get: function(obj, prop) {
        return prop in obj ?
            obj[prop] :
            37;
    }
};
let p;
for (let i = 1; i < 100000; i++) {
    p = new Proxy({}, handler);
}
console.log(p.a)

Start hammerhand play ground and visit any website in it, then execute the code in console, you will get this error:

Here is the related code

        if (window.Proxy) {
            window.Proxy = function (target, handler) {
                if (handler.get) {
                    const storedGet = handler.get;

                    handler.get = function (getterTarget, name, receiver) {
                        if (name === IS_PROXY_OBJECT_INTERNAL_PROP_NAME)
                            return IS_PROXY_OBJECT_INTERNAL_PROP_VALUE;

                        return storedGet.call(this, getterTarget, name, receiver);
                    };
                }

                return new nativeMethods.Proxy(target, handler);
            };
            window.Proxy.toString = () => nativeMethods.Proxy.toString();
            window.Proxy.revocable = nativeMethods.Proxy.revocable;
        }

I guess this bug can be fixed by checking if the handler has already been overwrite.

[Dmitry-Ostashev]

Thank you for your report and PR. We'll discuss it.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.