Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.22.1-alpha.2 broke testcafe-live #2920

Closed
sorin-davidoi opened this issue Oct 2, 2018 · 8 comments
Closed

0.22.1-alpha.2 broke testcafe-live #2920

sorin-davidoi opened this issue Oct 2, 2018 · 8 comments
Assignees
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Milestone

Comments

@sorin-davidoi
Copy link

sorin-davidoi commented Oct 2, 2018

Are you requesting a feature or reporting a bug?

Bug.

What is the current behavior?

Reloading a test doesn't work. Changes are picked up but the test doesn't restart (it gets stuck at Test run is starting...).

What is the expected behavior?

Reloading a test in testcafe-live works.

How would you reproduce the current behavior (if this is a bug)?

Run a test with testcafe-live and press Ctrl-R when it finished.

Specify your

  • operating system: macOS
  • testcafe version: 0.22.1-alpha.2
  • node.js version: v8.12.0

The bug is not present in 0.22.1-alpha.1.

I'm reporting it here since the regression happened in testcafe.

@AlexKamaev AlexKamaev self-assigned this Oct 3, 2018
@AlexKamaev
Copy link
Contributor

I was able to reproduce the issue only in two cases.

  1. A test does not restart if VSCode (I run tests via integrated terminal) is opened in full screen mode.
  2. If I close the browser and then press Ctrl+R in terminal.
    However both these cases are reproducible with the previous TextCafe version. If you able to recreate the issue without any extra conditions, could you please clarify which macOC version you are using? In which browser are you executing the tests? Could you provide a simple test project or screencast that demonstrates the problem?

@AlexKamaev AlexKamaev added the STATE: Need clarification An issue lacks information for further research. label Oct 3, 2018
@sorin-davidoi
Copy link
Author

It seems to be related to the number of tests:

  • if I place the attached test in demo.ts and run it with testcafe-live firefox demo.ts, reloading works just fine.
  • if I place the attached test it in tests/demo.ts (where tests contains ~60 other tests, none of which have .only) and run it with testcafe-live firefox tests reload doesn't work.
import { Selector } from 'testcafe';

fixture`Demo`.page('https://joinmastodon.org');

test.only('has get started button', async test => {
    await test.expect(Selector('a').withText('Get started').visible).ok();
});

macOS version: 10.13.0
Firefox version: 62.0.3 (though TestCafe reports it as 62.0.0)

@AlexKamaev
Copy link
Contributor

Thank you for providing this information. My attempts to replicate it, however, were unsuccessful. I can confirm that it works really slowly with more than 150 files, but it still does not fail.
I've attached my screencast illustrating my steps. Would you please review it and let me know what steps I need to perform in order to replicate the issue? https://drive.google.com/file/d/1WQlsjNSBOWu5CzC9vEbItFCqejlJVmYY/view?usp=sharing

@sorin-davidoi
Copy link
Author

I can't replicate it anymore 😕 (tested with exactly the same versions). Will close this now, thank you for taking the time to investigate!

@pciavald
Copy link

pciavald commented Dec 4, 2018

I'm getting this issue too on

{
  "scripts": {
    "test:live": "testcafe-live chrome ./tests/functional/**/*.js"
  },
  "devDependencies": {
    "testcafe": "^0.23.2",
    "testcafe-live": "^0.1.4"
  }
}

The tests run as expected, then this message appears :

Make changes in the source files or press ctrl+r to restart test run.

then when overwriting a file

Sources have been changed. Test run is starting...

but the browser does not react and no more log is outputted. Nothing happens. Pressing ctrl+r shows once and ctrl+s repeatedly :

Current test run is stopping...

ctrl+c stops correctly.

how can I help investigating ?

@AlexSkorkin AlexSkorkin reopened this Dec 5, 2018
@miherlosev miherlosev added TYPE: bug The described behavior is considered as wrong (bug). and removed STATE: Need clarification An issue lacks information for further research. labels Dec 10, 2018
@miherlosev miherlosev added this to the Planned milestone Dec 10, 2018
@miherlosev
Copy link
Contributor

Hi @pciavald

Thank you for the detailed description. I've reproduced the problem.

@AndreyBelym AndreyBelym modified the milestones: Planned, Sprint #24 Dec 12, 2018
@AndreyBelym
Copy link
Contributor

It will be resolved in the context of issue #3215

@lock
Copy link

lock bot commented Mar 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

No branches or pull requests

6 participants